Skip to content

Conversation

@averyjennings
Copy link

@averyjennings averyjennings commented Dec 15, 2025

  • Update default kubernetes_version in EKS module from 1.28 to 1.29
  • Update production EKS cluster to use Kubernetes 1.29
  • Aligns with latest EKS supported versions

Summary by CodeRabbit

  • Chores
    • Updated default Kubernetes version from 1.28 to 1.29 for EKS deployments across infrastructure configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

- Update default kubernetes_version in EKS module from 1.28 to 1.29
- Update production EKS cluster to use Kubernetes 1.29
- Aligns with latest EKS supported versions
@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

📝 Walkthrough

Walkthrough

Updated the default Kubernetes version from 1.28 to 1.29 across the EKS module variable definition and production Terragrunt configuration. No logic or structural changes applied.

Changes

Cohort / File(s) Summary
EKS Kubernetes version bump
modules/eks/variables.tf, prod/eks/terragrunt.hcl
Updated kubernetes_version default and input from "1.28" to "1.29" in both the variable definition and production configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple, repetitive version bump with no logic changes across two configuration files
  • No functional impact beyond version specification

Poem

🐰 A hop, a skip, from twenty-eight,
To twenty-nine—oh what a state!
Our Kubernetes hops along so bright,
Version bumped, everything's right! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade EKS to Kubernetes 1.29' directly and clearly summarizes the main changes: updating the EKS module and production configuration to use Kubernetes version 1.29.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/upgrade-kubernetes-1.29

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
prod/eks/terragrunt.hcl (1)

19-19: Verify Kubernetes 1.29 compatibility and explicitly pin addon versions for production stability.

Upgrading Kubernetes to 1.29 introduces breaking changes that require verification before production deployment. Several API deprecations and removals affect EKS clusters:

  • flowcontrol.apiserver.k8s.io/v1beta2 has been removed—migrate any FlowSchema or PriorityLevelConfiguration to v1 or v1beta3
  • Node.status.kubeProxyVersion is deprecated—review any tooling that reads this field
  • Service account token handling changes with LegacyServiceAccountTokenCleanup
  • In-tree cloud provider integrations are being disabled (KEP-2395)—test EKS-specific addons and credential flows

Critical for EKS: KMSv2 is enabled by default in Kubernetes 1.29 but is not currently supported in Amazon EKS. Do not enable KMSv2 on this cluster.

Audit your manifests and workloads for deprecated API usage before upgrading. Additionally, explicitly pin addon versions in the inputs rather than relying on module defaults to ensure predictable, reproducible upgrades:

inputs = {
  # ... existing inputs ...
  
  # Explicit addon versions for production stability
  vpc_cni_version    = "v1.x.x-eksbuild.y"
  coredns_version    = "v1.x.x-eksbuild.y"
  kube_proxy_version = "v1.x.x-eksbuild.y"
}

Confirm testing completed in staging/dev environments and a rollback plan is documented.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 34c3d06 and 8dbdcec.

📒 Files selected for processing (2)
  • modules/eks/variables.tf (1 hunks)
  • prod/eks/terragrunt.hcl (1 hunks)
🔇 Additional comments (1)
modules/eks/variables.tf (1)

14-14: EKS 1.29 is supported with compatible addon versions.

AWS officially supports Kubernetes 1.29 with compatible addon versions: VPC CNI v1.20.4, CoreDNS v1.11.4, and kube-proxy v1.29.15. The null defaults for addon versions (lines 80-96) follow standard AWS EKS practice—AWS auto-selects the appropriate compatible version. Existing configurations (prod and dev) explicitly set kubernetes_version, so they are unaffected by this default change. Only new environments without explicit version overrides will default to 1.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants