fix: gutter content child without descendants #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Jefiozie @SanderElias what about this PR? |
SanderElias
approved these changes
Oct 30, 2025
Contributor
SanderElias
left a comment
There was a problem hiding this comment.
LGTM.
Seeking deeper into the tree can only cause trouble
3959485 to
45e7cec
Compare
Collaborator
Author
|
@SanderElias I rebased so ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contentChilddefault behavior is to match descendants. For the gutter it means in nested splits the top split would get the same gutter defined in the inner split which I think is unexpected.@SanderElias @Jefiozie Do you see any reason we might want descendants matching for the gutter directive?
Closes #517