Replace the unsafe SIMD implementation with portable_simd #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that nightly supports portable_simd, we can attempt to replace the SIMD implementations with portable_simd.
In the current state, this does not avoid
unsafeentirely, because while theBlockDescriptorstruct is just a new-type foru16, Rust does not support a safe transmute to a u16 slice, which we need to load the data into SIMD registers.This can be solved by changing the
BlockDescriptorstruct into a type alias. Alternatively, we could change block descriptors fromu16to[u16; 16]to force alignment, which would make transmuting entirely obsolete, since we can just operate on the entire superblock.Since those decisions are part of #9, where we want to change the backing structs, and force alignment, this PR is blocked until those implementation choices are made.