Rework CommandArguments #663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerEchtePilz
requested changes
Aug 1, 2025
Member
DerEchtePilz
left a comment
There was a problem hiding this comment.
Generally fine, but there are a few things that need to be addressed.
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Outdated
Show resolved
Hide resolved
commandapi-core/src/main/java/dev/jorel/commandapi/executors/CommandArguments.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes core include
jspecifyandjetbrains-annotations(becausejspecifydoesn't cover every annotation yet). Only migratedCommandArgumentsto these libraries.Not sure if I correctly included these libraries, I don't use maven.
(Paper already includes both, Spigot only
jetbrains-annotationsiirc)