fix(eslint-plugin): [strict-bool-expr] treat unconstrained generic as any #3981
Conversation
[pull] master from typescript-eslint:master
|
Thanks for the PR, @phaux! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3981 +/- ##
==========================================
+ Coverage 92.83% 93.50% +0.67%
==========================================
Files 192 151 -41
Lines 8760 8143 -617
Branches 2690 2585 -105
==========================================
- Hits 8132 7614 -518
+ Misses 243 167 -76
+ Partials 385 362 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Super, thanks @phaux! 🚀
| }), | ||
|
|
||
| // any in boolean context | ||
| // TODO: when `T` is not `extends any` then the error is `conditionErrorObject` (says it's always truthy, which is false) |
There was a problem hiding this comment.
Haha, looks like the attached issue was already known at a point in time!
There was a problem hiding this comment.
Yup, but I had no idea how to fix it until now and just assumed it's a bug in TS
Fixes #3644