Grammar corrections in User guide FAQ #30665
Conversation
- Use "its" (the possessive form of "it") instead of "it's" (the contraction of "it is"). - Change plurality of verb to match compound subject joined by "or". The verb should agree with the part of the subject closest to it. See https://editorsmanual.com/articles/compound-subject-singular-or-plural/.
doc/users/faq.rst
Outdated
| We've decided not to include this as a figure method because this is only one | ||
| way of defining empty, and checking the above is only rarely necessary. | ||
| Usually the user or program handling the figure know if they have added | ||
| Usually the user or program handling the figure knows if it has added |
There was a problem hiding this comment.
| Usually the user or program handling the figure knows if it has added | |
| Usually the user (or program) handling the figure knows if they (it) has added |
I think the issue here is that user and program get different pronouns and casting to passive voice won't work b/c the ownership is what's important.
There was a problem hiding this comment.
If we parenthesize "or program" and "it", we should change "has" to "have" in order to match the pronoun "they". (Sorry I don't know how to modify a suggested change directly.)
There was a problem hiding this comment.
Couldn't we simply write
| Usually the user or program handling the figure knows if it has added | |
| Usually the user or program handling the figure know if they have added |
?
There was a problem hiding this comment.
It's a bad combination of count/program/conjugation agreement.
A user knows what changes they have made and a program knows what changes it has made.
There was a problem hiding this comment.
Ask an LLM. They are good at this. 😃 - I leave this to whoever cares because there’s not the one correct answer, and I as non-native speaker are not particularly qualified to judge.
Restructure sentence to avoid subject/pronoun/verb disagreement.
| way of defining empty, and checking the above is only rarely necessary. | ||
| Usually the user or program handling the figure know if they have added | ||
| something to the figure. | ||
| Whether or not something has been added to the figure is usually defined |
There was a problem hiding this comment.
| Whether or not something has been added to the figure is usually defined | |
| Whether or not something has been added to the figure is usually defined |
PR summary
Minor grammar corrections in existing documentation.
PR checklist