CookieSessionStore requiring two authentications to persist user #2802
+80
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling session.value() twice in the same request caused the session data to be corrupted when no session cookie existed. This made the first login fail to persist the user, requiring a second authentication. The fix is to separate initial cookie creation from subsequent cookie updates so session.value() is only invoked once. Also adjust SessionHandlerImpl to persist the authenticated user correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2765: CookieSessionStore requires twice auth on first login
Calling session.value() twice in the same request caused the session data
to be corrupted when no session cookie existed. This made the first login
fail to persist the user, requiring a second authentication. The fix is to
separate initial cookie creation from subsequent cookie updates so
session.value() is only invoked once. Also adjust SessionHandlerImpl to
persist the authenticated user correctly.