Skip to content

fix: update execScript message in no-implied-eval rule #19937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fasttime merged 1 commit into from
Jul 15, 2025
Merged

fix: update execScript message in no-implied-eval rule #19937

fasttime merged 1 commit into from
Jul 15, 2025

Conversation

@TKDev7
Copy link
Contributor

@TKDev7 TKDev7 commented Jul 12, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Updated the error message shown by the no-implied-eval rule when execScript() is used. The new message is more accurate, since execScript() does not accept a function as an argument, and the only resolution is to avoid using it.
  • Added and improved test coverage for execScript.

Fixes #19927

Is there anything you'd like reviewers to focus on?

@TKDev7 TKDev7 requested a review from a team as a code owner July 12, 2025 14:48
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 12, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jul 12, 2025
@netlify
Copy link

netlify bot commented Jul 12, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 82f6130
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/687275c4f6e6490008171ac5

@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jul 12, 2025
@TKDev7 TKDev7 mentioned this pull request Jul 12, 2025
Closed
1 task
@mdjermanovic mdjermanovic added contributor pool accepted There is consensus among the team that this change meets the criteria for inclusion labels Jul 13, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Jul 13, 2025
mdjermanovic
mdjermanovic approved these changes Jul 13, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving it open for a couple more days if anyone else would like to review it. Also, we need to wait for #19912 to conclude before merging.

@mdjermanovic mdjermanovic moved this from Implementing to Merge Candidates in Triage Jul 13, 2025
fasttime
fasttime approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 3173305 into eslint:main Jul 15, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly contributor pool rule Relates to ESLint's core rules

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule Change: Update execScript message in no-implied-eval rule

3 participants

@TKDev7 @fasttime @mdjermanovic