Skip to content

Conversation

@nzakas
Copy link
Member

@nzakas nzakas commented Jun 9, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Refactor

What changes did you make? (Give an overview)

This refactor removes @eslint/eslintrc from flat config-specific functionality. In order to do this, I had to add back the naming and ModuleResolver utilities that were previous extracted into @eslint/eslintrc. These are necessary primarily to enable loading of formatters.

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner June 9, 2025 15:08
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 9, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 9, 2025
@netlify
Copy link

netlify bot commented Jun 9, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 4e1a655
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6848465ccd7bab00080d8974

@github-actions github-actions bot added cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features labels Jun 9, 2025
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Jun 10, 2025
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 10, 2025
@fasttime fasttime moved this from Triaging to Implementing in Triage Jun 10, 2025
Copy link
Member

@fasttime fasttime Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused empty file? It seems that only file2.js is used.

nzakas and others added 2 commits June 10, 2025 10:50
Co-authored-by: Francesco Trotta <github@fasttime.org>
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit a806994 into main Jun 10, 2025
30 checks passed
@fasttime fasttime deleted the eslintrc-removal branch June 10, 2025 17:04
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants