-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat: add ecmaVersion: 2026, parsing using and await using
#19832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like another review before merging.
|
@mdjermanovic there's a merge conflict now |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving.
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
Refs #19792
Adds
ecmaVersion: 2026and enables parsing new syntax from the Explicit Resource Management proposal, that isusingandawait usingdeclarations.What changes did you make? (Give an overview)
espreeandeslint-scopedependencies.2026.AsyncDisposableStack,DisposableStack,SuppressedError.Is there anything you'd like reviewers to focus on?
Waiting for eslint/js#658.Did I miss anything else that should be updated?