fix: report only global references in no-implied-eval (#19932)

snitin315 · mdjermanovic · web-flow · commit f46fc6c137c9 · 2025-07-19T10:41:24.000+02:00
* fix: report only global references in no-implied-eval

* chore: fix formatting

* test: add more cases

* docs: fix examples

* chore: apply suggestions from code review

Co-authored-by: Milos Djermanovic &lt;milos.djermanovic@gmail.com&gt;

---------

Co-authored-by: Milos Djermanovic &lt;milos.djermanovic@gmail.com&gt;
diff --git a/docs/src/rules/no-implied-eval.md b/docs/src/rules/no-implied-eval.md
@@ -35,7 +35,7 @@ Examples of **incorrect** code for this rule:
 
 ```js
 /*eslint no-implied-eval: "error"*/
-/*global window*/
+/*global window, setTimeout, setInterval, execScript*/
 
 setTimeout("alert('Hi!');", 100);
 
@@ -56,6 +56,7 @@ Examples of **correct** code for this rule:
 
 ```js
 /*eslint no-implied-eval: "error"*/
+/*global setTimeout, setInterval*/
 
 setTimeout(function() {
     alert("Hi!");
diff --git a/lib/rules/no-implied-eval.js b/lib/rules/no-implied-eval.js
@@ -145,7 +145,11 @@ module.exports = {
 		return {
 			CallExpression(node) {
 				if (
-					astUtils.isSpecificId(node.callee, EVAL_LIKE_FUNC_PATTERN)
+					astUtils.isSpecificId(
+						node.callee,
+						EVAL_LIKE_FUNC_PATTERN,
+					) &&
+					sourceCode.isGlobalReference(node.callee)
 				) {
 					reportImpliedEvalCallExpression(node);
 				}
diff --git a/tests/lib/rules/no-implied-eval.js b/tests/lib/rules/no-implied-eval.js
