fix: allow separate default and named type imports (#19899)

xbinaryx · web-flow · commit e91bb870f8c6 · 2025-07-01T21:27:19.000+02:00
* fix: allow separate default and named type imports in no-duplicate-imports

* fix default import and named export
diff --git a/lib/rules/no-duplicate-imports.js b/lib/rules/no-duplicate-imports.js
@@ -66,6 +66,20 @@ function isImportExportCanBeMerged(node1, node2) {
 	const importExportType1 = getImportExportType(node1);
 	const importExportType2 = getImportExportType(node2);
 
+	if (
+		(node1.importKind === "type" || node1.exportKind === "type") &&
+		(node2.importKind === "type" || node2.exportKind === "type")
+	) {
+		const isDefault1 = importExportType1 === "ImportDefaultSpecifier";
+		const isDefault2 = importExportType2 === "ImportDefaultSpecifier";
+		const isNamed1 = isImportExportSpecifier(importExportType1, "named");
+		const isNamed2 = isImportExportSpecifier(importExportType2, "named");
+
+		if ((isDefault1 && isNamed2) || (isDefault2 && isNamed1)) {
+			return false;
+		}
+	}
+
 	if (
 		(importExportType1 === "ExportAll" &&
 			importExportType2 !== "ExportAll" &&
diff --git a/tests/lib/rules/no-duplicate-imports.js b/tests/lib/rules/no-duplicate-imports.js
@@ -247,6 +247,7 @@ ruleTesterTypeScript.run("no-duplicate-imports", rule, {
 		'import type * as Bar from "os";\nimport { type Baz } from "os";',
 		'import foo, * as bar from "os";\nimport { type Baz } from "os";',
 		'import foo, { type bar } from "os";\nimport type * as Baz from "os";',
+		'import type { Merge } from "lodash-es";\nimport type _ from "lodash-es";',
 		{
 			code: 'import type Os from "os";\nexport { type Hello } from "hello";',
 			options: [{ includeExports: true }],
@@ -283,6 +284,10 @@ ruleTesterTypeScript.run("no-duplicate-imports", rule, {
 			code: 'import type Os from "os";\nexport * from "os";',
 			options: [{ includeExports: true }],
 		},
+		{
+			code: 'import type Os from "os";\nexport type { Something } from "os";',
+			options: [{ includeExports: true }],
+		},
 		{
 			code: 'export type { Something } from "os";\nexport * from "os";',
 			options: [{ includeExports: true }],
@@ -361,16 +366,6 @@ ruleTesterTypeScript.run("no-duplicate-imports", rule, {
 				},
 			],
 		},
-		{
-			code: 'import type { Merge } from "lodash-es";\nimport type _ from "lodash-es";',
-			errors: [
-				{
-					messageId: "import",
-					data: { module: "lodash-es" },
-					type: "ImportDeclaration",
-				},
-			],
-		},
 		{
 			code: 'import type Os from "os";\nimport type { Something } from "os";\nimport type * as Foobar from "os";',
 			errors: [
@@ -379,11 +374,6 @@ ruleTesterTypeScript.run("no-duplicate-imports", rule, {
 					data: { module: "os" },
 					type: "ImportDeclaration",
 				},
-				{
-					messageId: "import",
-					data: { module: "os" },
-					type: "ImportDeclaration",
-				},
 			],
 		},
 		{
