feat: throw error when column is negative in getIndexFromLoc (#19831)

lumirlumir · web-flow · commit b8a7e7aeb5f0 · 2025-06-18T11:35:40.000+02:00
* fix: handle negative column index in `getIndexFromLoc` and add tests

* wip: address comments

* wip: add more test cases
diff --git a/lib/languages/js/source-code/source-code.js b/lib/languages/js/source-code/source-code.js
@@ -816,6 +816,12 @@ class SourceCode extends TokenStore {
 			);
 		}
 
+		if (loc.column < 0) {
+			throw new RangeError(
+				`Invalid column number (column ${loc.column} requested).`,
+			);
+		}
+
 		const lineStartIndex = this.lineStartIndices[loc.line - 1];
 		const lineEndIndex =
 			loc.line === this.lineStartIndices.length
diff --git a/tests/lib/languages/js/source-code/source-code.js b/tests/lib/languages/js/source-code/source-code.js
@@ -2339,6 +2339,21 @@ describe("SourceCode", () => {
 		});
 
 		it("should throw a useful error if `column` is out of range", () => {
+			assert.throws(
+				() => sourceCode.getIndexFromLoc({ line: 1, column: -1 }),
+				"Invalid column number (column -1 requested).",
+			);
+
+			assert.throws(
+				() => sourceCode.getIndexFromLoc({ line: 1, column: -5 }),
+				"Invalid column number (column -5 requested).",
+			);
+
+			assert.throws(
+				() => sourceCode.getIndexFromLoc({ line: 3, column: -1 }),
+				"Invalid column number (column -1 requested).",
+			);
+
 			assert.throws(
 				() => sourceCode.getIndexFromLoc({ line: 3, column: 4 }),
 				/Column number out of range \(column 4 requested, but the length of line 3 is 4\)\./u,
