feat: ignore type annotations in no-restricted-globals (#19781)

sethamus · web-flow · commit 342bd29e1a10 · 2025-06-04T04:20:40.000+05:30
diff --git a/docs/src/rules/no-restricted-globals.md b/docs/src/rules/no-restricted-globals.md
@@ -106,3 +106,25 @@ function onClick() {
 ```
 
 :::
+
+Restricted globals used in TypeScript type annotations—such as type references, interface inheritance, or class implementations—are ignored by this rule.
+
+Examples of **correct** TypeScript code for "Promise", "Event", and "Window" global variable names:
+
+::: correct
+
+```ts
+/*eslint no-restricted-globals: ["error", "Promise", "Event", "Window"]*/
+
+const fetchData: Promise<string> = fetchString();
+
+interface CustomEvent extends Event {}
+
+class CustomWindow implements Window {}
+
+function handleClick(event: Event) {
+  console.log(event);
+}
+```
+
+:::
diff --git a/lib/rules/no-restricted-globals.js b/lib/rules/no-restricted-globals.js
@@ -4,13 +4,27 @@
  */
 "use strict";
 
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+const TYPE_NODES = new Set([
+	"TSTypeReference",
+	"TSInterfaceHeritage",
+	"TSClassImplements",
+	"TSTypeQuery",
+	"TSQualifiedName",
+]);
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
 
 /** @type {import('../types').Rule.RuleModule} */
 module.exports = {
 	meta: {
+		dialects: ["javascript", "typescript"],
+		language: "javascript",
 		type: "suggestion",
 
 		docs: {
@@ -100,20 +114,39 @@ module.exports = {
 			return Object.hasOwn(restrictedGlobalMessages, name);
 		}
 
+		/**
+		 * Check if the given reference occurs within a TypeScript type context.
+		 * @param {Reference} reference The variable reference to check.
+		 * @returns {boolean} Whether the reference is in a type context.
+		 * @private
+		 */
+		function isInTypeContext(reference) {
+			const parent = reference.identifier.parent;
+
+			return TYPE_NODES.has(parent.type);
+		}
+
 		return {
 			Program(node) {
 				const scope = sourceCode.getScope(node);
 
 				// Report variables declared elsewhere (ex: variables defined as "global" by eslint)
 				scope.variables.forEach(variable => {
 					if (!variable.defs.length && isRestricted(variable.name)) {
-						variable.references.forEach(reportReference);
+						variable.references.forEach(reference => {
+							if (!isInTypeContext(reference)) {
+								reportReference(reference);
+							}
+						});
 					}
 				});
 
 				// Report variables not declared at all
 				scope.through.forEach(reference => {
-					if (isRestricted(reference.identifier.name)) {
+					if (
+						isRestricted(reference.identifier.name) &&
+						!isInTypeContext(reference)
+					) {
 						reportReference(reference);
 					}
 				});
diff --git a/tests/lib/rules/no-restricted-globals.js b/tests/lib/rules/no-restricted-globals.js
