feat: prune suppressions for non-existent files (#19825)

TKDev7 · web-flow · commit 19cdd226bb59 · 2025-06-10T17:59:52.000+02:00
diff --git a/lib/services/suppressions-service.js b/lib/services/suppressions-service.js
@@ -112,6 +112,14 @@ class SuppressionsService {
 			}
 		}
 
+		for (const file of Object.keys(suppressions)) {
+			const absolutePath = path.resolve(this.cwd, file);
+
+			if (!fs.existsSync(absolutePath)) {
+				delete suppressions[file];
+			}
+		}
+
 		return this.save(suppressions);
 	}
 
diff --git a/tests/bin/eslint.js b/tests/bin/eslint.js
@@ -1178,6 +1178,33 @@ describe("bin/eslint.js", () => {
 					);
 				});
 			});
+
+			it("prunes suppressions for files that don't exist", () => {
+				const suppressions = structuredClone(
+					SUPPRESSIONS_FILE_ALL_ERRORS,
+				);
+				const nonExistentFile =
+					"tests/fixtures/suppressions/non-existent-file.js";
+
+				suppressions[nonExistentFile] = {
+					"no-undef": { count: 1 },
+				};
+
+				fs.writeFileSync(
+					SUPPRESSIONS_PATH,
+					JSON.stringify(suppressions, null, 2),
+				);
+
+				const child = runESLint(ARGS_WITH_PRUNE_SUPPRESSIONS);
+
+				return assertExitCode(child, 0).then(() => {
+					assert.deepStrictEqual(
+						JSON.parse(fs.readFileSync(SUPPRESSIONS_PATH, "utf8")),
+						SUPPRESSIONS_FILE_ALL_ERRORS,
+						"Suppressions for existing files should remain unchanged",
+					);
+				});
+			});
 		});
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,14 @@ class SuppressionsService {`
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`
	`115`	`+ for (const file of Object.keys(suppressions)) {`
	`116`	`+ const absolutePath = path.resolve(this.cwd, file);`
	`117`	`+`
	`118`	`+ if (!fs.existsSync(absolutePath)) {`
	`119`	`+ delete suppressions[file];`
	`120`	`+ }`
	`121`	`+ }`
	`122`	`+`
`115`	`123`	`return this.save(suppressions);`
`116`	`124`	`}`
`117`	`125`