chore: enable eslint recommended config

43081j · 43081j · commit ec02d4f4c695 · 2025-01-07T21:31:25.000Z
Enables the recommended lint rules from `eslint`.

Also deletes `getEnumerableProperties.js` which is no longer referenced.
diff --git a/eslint.config.js b/eslint.config.js
@@ -1,12 +1,26 @@
 import jsdoc from "eslint-plugin-jsdoc";
+import eslintjs from "@eslint/js";
+
+const {configs: eslintConfigs} = eslintjs;
 
 export default [
   jsdoc.configs["flat/recommended"],
+  eslintConfigs["recommended"],
   {
+    languageOptions: {
+      // if we ever use more globals than this, pull in the `globals` package
+      globals: {
+        console: false
+      }
+    },
     rules: {
       "jsdoc/require-param-description": "off",
       "jsdoc/require-returns-description": "off",
       "jsdoc/tag-lines": ["error", "any", { startLines: 1 }],
+      "no-unused-vars": ["error", {
+        argsIgnorePattern: "^_",
+        caughtErrorsIgnorePattern: "^_"
+      }]
     },
   },
 ];
diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js
@@ -727,7 +727,7 @@ Assertion.addProperty('callable', function () {
   const negate = flag(this, 'negate');
 
   const assertionMessage = negate ?
-    `${msg}expected ${_.inspect(val)} not to be a callable function` : 
+    `${msg}expected ${_.inspect(val)} not to be a callable function` :
     `${msg}expected ${_.inspect(val)} to be a callable function`;
 
   const isCallable = ['Function', 'AsyncFunction', 'GeneratorFunction', 'AsyncGeneratorFunction'].includes(_.type(val));
@@ -1424,7 +1424,7 @@ function assertBelow (n, msg) {
   if (doLength && objType !== 'map' && objType !== 'set') {
     new Assertion(obj, flagMsg, ssfi, true).to.have.property('length');
   }
-  
+
   if (!doLength && (objType === 'date' && nType !== 'date')) {
     errorMessage = msgPrefix + 'the argument to below must be a date';
   } else if (!_.isNumeric(n) && (doLength || _.isNumeric(obj))) {
@@ -1744,7 +1744,7 @@ function assertInstanceOf (constructor, msg) {
     , 'expected #{this} to be an instance of ' + name
     , 'expected #{this} to not be an instance of ' + name
   );
-};
+}
 
 Assertion.addMethod('instanceof', assertInstanceOf);
 Assertion.addMethod('instanceOf', assertInstanceOf);
@@ -1951,11 +1951,11 @@ Assertion.addMethod('property', assertProperty);
 
 /**
  *
- * @param {unknown} name
- * @param {unknown} value
- * @param {string} msg
+ * @param {unknown} _name
+ * @param {unknown} _value
+ * @param {string} _msg
  */
-function assertOwnProperty (name, value, msg) {
+function assertOwnProperty (_name, _value, _msg) {
   flag(this, 'own', true);
   assertProperty.apply(this, arguments);
 }
@@ -2409,7 +2409,7 @@ function assertKeys (keys) {
     actual = [];
 
     // Map and Set '.keys' aren't supported in IE 11. Therefore, use .forEach.
-    obj.forEach(function (val, key) { actual.push(key) });
+    obj.forEach(function (_val, key) { actual.push(key) });
 
     if (keysType !== 'Array') {
       keys = Array.prototype.slice.call(arguments);
@@ -2808,7 +2808,7 @@ function assertThrows (errorLike, errMsgMatcher, msg) {
   }
 
   flag(this, 'object', caughtErr);
-};
+}
 
 Assertion.addMethod('throw', assertThrows);
 Assertion.addMethod('throws', assertThrows);
@@ -3923,7 +3923,7 @@ Assertion.addProperty('frozen', function() {
  * @namespace BDD
  * @public
  */
-Assertion.addProperty('finite', function(msg) {
+Assertion.addProperty('finite', function() {
   var obj = flag(this, 'object');
 
   this.assert(
diff --git a/lib/chai/interface/assert.js b/lib/chai/interface/assert.js
@@ -713,7 +713,7 @@ assert.isNotNumber = function (val, msg) {
  *
  *     var cups = 2;
  *     assert.isNumeric(cups, 'how many cups');
- * 
+ *
  *     var cups = 10n;
  *     assert.isNumeric(cups, 'how many cups');
  *
@@ -3031,21 +3031,22 @@ assert.isNotEmpty = function(val, msg) {
  * @param {unknown} as
  * @returns {unknown}
  */
-(function alias(name, as){
+const aliases = [
+  ['isOk', 'ok'],
+  ['isNotOk', 'notOk'],
+  ['throws', 'throw'],
+  ['throws', 'Throw'],
+  ['isExtensible', 'extensible'],
+  ['isNotExtensible', 'notExtensible'],
+  ['isSealed', 'sealed'],
+  ['isNotSealed', 'notSealed'],
+  ['isFrozen', 'frozen'],
+  ['isNotFrozen', 'notFrozen'],
+  ['isEmpty', 'empty'],
+  ['isNotEmpty', 'notEmpty'],
+  ['isCallable', 'isFunction'],
+  ['isNotCallable', 'isNotFunction']
+];
+for (const [name, as] of aliases) {
   assert[as] = assert[name];
-  return alias;
-})
-('isOk', 'ok')
-('isNotOk', 'notOk')
-('throws', 'throw')
-('throws', 'Throw')
-('isExtensible', 'extensible')
-('isNotExtensible', 'notExtensible')
-('isSealed', 'sealed')
-('isNotSealed', 'notSealed')
-('isFrozen', 'frozen')
-('isNotFrozen', 'notFrozen')
-('isEmpty', 'empty')
-('isNotEmpty', 'notEmpty')
-('isCallable', 'isFunction')
-('isNotCallable', 'isNotFunction')
+}
diff --git a/lib/chai/utils/getEnumerableProperties.js b/lib/chai/utils/getEnumerableProperties.js
diff --git a/lib/chai/utils/proxify.js b/lib/chai/utils/proxify.js
@@ -56,6 +56,8 @@ export function proxify(obj ,nonChainableMethodName) {
         var suggestionDistance = 4;
         getProperties(target).forEach(function(prop) {
           if (
+            // we actually mean to check `Object.prototype` here
+            // eslint-disable-next-line no-prototype-builtins
             !Object.prototype.hasOwnProperty(prop) &&
             builtins.indexOf(prop) === -1
           ) {
@@ -119,17 +121,17 @@ function stringDistanceCapped(strA, strB, cap) {
   // `memo` is a two-dimensional array containing distances.
   // memo[i][j] is the distance between strA.slice(0, i) and
   // strB.slice(0, j).
-  for (var i = 0; i <= strA.length; i++) {
+  for (let i = 0; i <= strA.length; i++) {
     memo[i] = Array(strB.length + 1).fill(0);
     memo[i][0] = i;
   }
-  for (var j = 0; j < strB.length; j++) {
+  for (let j = 0; j < strB.length; j++) {
     memo[0][j] = j;
   }
 
-  for (var i = 1; i <= strA.length; i++) {
+  for (let i = 1; i <= strA.length; i++) {
     var ch = strA.charCodeAt(i - 1);
-    for (var j = 1; j <= strB.length; j++) {
+    for (let j = 1; j <= strB.length; j++) {
       if (Math.abs(i - j) >= cap) {
         memo[i][j] = cap;
         continue;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -49,6 +49,7 @@
     "pathval": "^2.0.0"
   },
   "devDependencies": {
+    "@eslint/js": "^9.17.0",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@web/dev-server-rollup": "^0.6.1",
     "@web/test-runner": "^0.18.0",
