Skip to content

Conversation

@Perryvw
Copy link
Member

@Perryvw Perryvw commented Dec 25, 2024

No description provided.

@Z3rio
Copy link
Contributor

Z3rio commented Dec 26, 2024

This does not take cases such as

new Array(length)
new Array(item1, item2)

into account, it would just overwrite both of them into [], no?

@Perryvw
Copy link
Member Author

Perryvw commented Dec 27, 2024

This does not take cases such as

new Array(length)
new Array(item1, item2)

into account, it would just overwrite both of them into [], no?

Good call, I supported the new Array(item1, item2) syntax too now (simply becomes { item1, item2 }), constructing array with predefined length is not supported due to Lua struggling with nils in arrays, I added a diagnostic in that case

@Perryvw Perryvw merged commit 6dfe252 into master Dec 28, 2024
4 checks passed
@Perryvw Perryvw deleted the new-array branch December 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants