Skip to content

Update k8s API for kubectl-pg and regen generated code #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

Update k8s API for kubectl-pg and regen generated code #2158

merged 1 commit into from
Jan 4, 2023

Conversation

@dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Jan 3, 2023

This PR updates k8s API version for the kubectl-pg CLI sub-project, adds vendor into the .gitignore and regen generated code with new 2023 year substitution 🎉

@FxKu
Copy link
Member

FxKu commented Jan 3, 2023 •
edited
Loading

I was about to do the same 😃

Can we switch to a higher K8s version than v0.23.5 (maybe rebase because we merged #1854)? Maybe v0.25.5?
Maybe we can also bump go version to 1.18.

@dmvolod
Copy link
Contributor Author

dmvolod commented Jan 4, 2023

I was about to do the same smiley

Oh, didn't know about this

Can we switch to a higher K8s version than v0.23.5 (maybe rebase because we merged #1854)? Maybe v0.25.5? Maybe we can also bump go version to 1.18.

Are you talking about whole project update to the k8s API version for whole project or just for the kebectl-pg?
In this case, golang version for the k8s API and client-go should be in sync with parent projects, i.e.
https://github.com/kubernetes/client-go/blob/v0.24.9/go.mod
https://github.com/kubernetes/kubernetes/blob/v1.24.9/go.mod

From support point of view, k8s community guaranties interoperability between client (operator) and k8s servers in the ±1 version. In this case, k8s API v0.24.9 will support k8s from v1.23.x to v1.25.x.

@FxKu
Copy link
Member

FxKu commented Jan 4, 2023

then let's stick to 0.23.5 because we are only jumping on K8s 1.22

@FxKu
Copy link
Member

FxKu commented Jan 4, 2023

👍

1 similar comment
@jopadi
Copy link
Member

jopadi commented Jan 4, 2023

👍

@FxKu FxKu added this to the 1.9 milestone Jan 4, 2023
@FxKu FxKu merged commit 9c88fb9 into zalando:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@dmvolod @FxKu @jopadi