Skip to content

Incorrect function call in User controller #2435

@szporwolik

Description

@szporwolik

I might be wrong on that, but it seems there is a bug in the User controller:

Line:

$this->input->post('oqrs_grouped_search') ?? 'off',

This is call to add method of User model, the last parameters are:

				$this->input->post('clubstation') == '1' ? true : false,
				$this->input->post('global_oqrs_text') ?? '',
				$this->input->post('oqrs_grouped_search') ?? 'off',
				$this->input->post('oqrs_grouped_search_show_station_name') ?? 'off',
				$this->input->post('oqrs_auto_matching') ?? 'on',
				$this->input->post('oqrs_direct_auto_matching') ?? 'on')

While the actual function parameters are ending with:

$qso_widget_display_qso_time, 
$dashboard_banner,
$dashboard_solar, $clubstation = 0) {

function add($username, $password, $email, $type, $firstname, $lastname, $callsign, $locator, $timezone,

Per my understanding those parameters never get handled by the method and if they would, probably the same error as #2429 (comment) would be triggered.

It seems the bug was introduced by 554a98e .

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingwait 4 closeIssue is wating for closing by issuer

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions