fix(eslint-plugin): [no-base-to-string] check if superclass is ignored #11617

thebolarin · 2025-09-18T16:20:13Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-base-to-string] should check if superclass is ignored #11520
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Added isIgnoredTypeOrBase to ensure that a type’s superclass or extended interfaces are properly checked against the ignored types list.

typescript-eslint · 2025-09-18T16:20:17Z

Thanks for the PR, @thebolarin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-09-18T16:20:18Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`68d0f69`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68d1b3a22e73ef000850749f
😎 Deploy Preview	https://deploy-preview-11617--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 4 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-09-18T16:21:47Z

View your CI Pipeline Execution ↗ for commit 68d0f69

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 13s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 4s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (27)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-22 20:44:07 UTC

codecov · 2025-09-18T16:33:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (c198052) to head (68d0f69).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11617   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51370    51394   +24     
  Branches     8476     8482    +6     
=======================================
+ Hits        46711    46735   +24     
  Misses       4646     4646           
  Partials       13       13

Flag	Coverage Δ
unittest	`90.93% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`99.06% <100.00%> (+0.07%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

Looks great to me, nicely done! 🚀

Just a couple of optional small refactor suggestions. Nothing major or blocking.

packages/eslint-plugin/src/rules/no-base-to-string.ts

thebolarin · 2025-09-22T18:59:38Z

@JoshuaKGoldberg Thanks for the review. I've also pushed a commit to adopt your suggestions

JoshuaKGoldberg

🙌 thanks!

@thebolarin

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 | | npm | @typescript-eslint/parser | 8.44.1 | 8.45.0 | ## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29) ##### 🚀 Features - **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614)) - **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617)) ##### ❤️ Thank You - mdm317 - Moses Odutusin [@thebolarin](https://github.com/thebolarin) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@thebolarin

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 | | npm | @typescript-eslint/parser | 8.44.1 | 8.45.0 | ## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29) ##### 🚀 Features - **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614)) - **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617)) ##### ❤️ Thank You - mdm317 - Moses Odutusin [@thebolarin](https://github.com/thebolarin) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@thebolarin

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 | | npm | @typescript-eslint/parser | 8.44.1 | 8.45.0 | ## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29) ##### 🚀 Features - **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614)) - **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617)) ##### ❤️ Thank You - mdm317 - Moses Odutusin [@thebolarin](https://github.com/thebolarin) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@thebolarin

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.44.1 | 8.45.0 | | npm | @typescript-eslint/parser | 8.44.1 | 8.45.0 | ## [v8.45.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29) ##### 🚀 Features - **eslint-plugin:** expose rule name via RuleModule interface ([#11616](typescript-eslint/typescript-eslint#11616)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#11614](typescript-eslint/typescript-eslint#11614)) - **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#11617](typescript-eslint/typescript-eslint#11617)) ##### ❤️ Thank You - mdm317 - Moses Odutusin [@thebolarin](https://github.com/thebolarin) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

webmaster128 · 2025-10-22T09:20:05Z

💐

to include this fix: typescript-eslint/typescript-eslint#11617

JoshuaKGoldberg mentioned this pull request Sep 22, 2025

Repo: Write lint rule to prefer tsutils methods over bitwise checks #11625

Open

JoshuaKGoldberg previously approved these changes Sep 22, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-base-to-string.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-base-to-string.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 22, 2025

thebolarin dismissed JoshuaKGoldberg’s stale review via 88cfdc3 September 22, 2025 18:38

thebolarin added 5 commits September 22, 2025 19:53

chore: check if superclass is ignored

92d6a8b

chore: fix linting issues

e6efdec

chore: increase code coverage

0a5090d

chore: add more test

fb612b4

chore: adds requested changes

584d8bf

thebolarin force-pushed the fix/superclass-ignored-check branch from 88cfdc3 to 584d8bf Compare September 22, 2025 18:57

thebolarin added 2 commits September 22, 2025 20:35

chore: fix format issues

a92783a

chore: trigger ci

68d0f69

JoshuaKGoldberg approved these changes Sep 25, 2025

View reviewed changes

JoshuaKGoldberg changed the title ~~feat(eslint-plugin): [no-base-to-string] check if superclass is ignored~~ fix(eslint-plugin): [no-base-to-string] check if superclass is ignored Sep 29, 2025

JoshuaKGoldberg merged commit 590fac6 into typescript-eslint:main Sep 29, 2025
65 checks passed

chrisbbreuer mentioned this pull request Sep 29, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#64

Closed

ArnaudBarre added a commit to ArnaudBarre/tsl that referenced this pull request Oct 1, 2025

Port typescript-eslint/typescript-eslint#11617

d059aaa

chrisbbreuer mentioned this pull request Oct 4, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

This was referenced Oct 6, 2025

chore(deps-dev): bump the dependencies group with 4 updates openfga/js-sdk#263

Merged

Bump @typescript-eslint/eslint-plugin from 8.44.1 to 8.46.0 fossas/fossa-action#220

Merged

webmaster128 added a commit to cosmos/cosmjs that referenced this pull request Oct 22, 2025

Upgrade @typescript-eslint/*

4b0d51e

to include this fix: typescript-eslint/typescript-eslint#11617

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-base-to-string] check if superclass is ignored #11617

fix(eslint-plugin): [no-base-to-string] check if superclass is ignored #11617

thebolarin commented Sep 18, 2025 •

edited

Loading

Uh oh!

typescript-eslint bot commented Sep 18, 2025

Uh oh!

netlify bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

thebolarin commented Sep 22, 2025

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

webmaster128 commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(eslint-plugin): [no-base-to-string] check if superclass is ignored #11617

fix(eslint-plugin): [no-base-to-string] check if superclass is ignored #11617

Conversation

thebolarin commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Sep 18, 2025

Uh oh!

netlify bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thebolarin commented Sep 22, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webmaster128 commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thebolarin commented Sep 18, 2025 •

edited

Loading

netlify bot commented Sep 18, 2025 •

edited

Loading

nx-cloud bot commented Sep 18, 2025 •

edited

Loading

codecov bot commented Sep 18, 2025 •

edited

Loading