Skip to content

Conversation

@KuSh
Copy link
Contributor

@KuSh KuSh commented Aug 28, 2025

PR Checklist

Overview

Use minimatch dot option to take file starting with a dot into account when configuring allowDefaultProject using globs

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @KuSh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a1fb6cf
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68b896b6c007b40007a2442d
😎 Deploy Preview https://deploy-preview-11537--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 22 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@KuSh KuSh changed the title fix(typescript-estree): Match filenames starting with a period when using glob in allowDefaultProject fix(typescript-estree): match filenames starting with a period when using glob in allowDefaultProject Aug 28, 2025
@nx-cloud
Copy link

nx-cloud bot commented Aug 28, 2025

View your CI Pipeline Execution ↗ for commit a1fb6cf

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 55s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run integration-tests:test ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-03 19:33:21 UTC

@KuSh KuSh force-pushed the main branch 3 times, most recently from 0c2e83a to 7120477 Compare August 28, 2025 19:49
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (f0e64eb) to head (a1fb6cf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11537   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files         505      505           
  Lines       51155    51157    +2     
  Branches     8424     8425    +1     
=======================================
+ Hits        46503    46505    +2     
  Misses       4639     4639           
  Partials       13       13           
Flag Coverage Δ
unittest 90.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...escript-estree/src/useProgramFromProjectService.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 3, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks! 🤗

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 3, 2025
KuSh and others added 2 commits September 3, 2025 21:24
…sing glob in allowDefaultProject

Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
…ice.test.ts

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@JoshuaKGoldberg JoshuaKGoldberg merged commit f780c1d into typescript-eslint:main Sep 8, 2025
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Match filenames starting with a period when using glob in allowDefaultProject

2 participants