-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(typescript-estree): match filenames starting with a period when using glob in allowDefaultProject #11537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, @KuSh! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit a1fb6cf
☁️ Nx Cloud last updated this comment at |
0c2e83a to
7120477
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11537 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 505 505
Lines 51155 51157 +2
Branches 8424 8425 +1
=======================================
+ Hits 46503 46505 +2
Misses 4639 4639
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thanks! 🤗
packages/typescript-estree/tests/lib/useProgramFromProjectService.test.ts
Outdated
Show resolved
Hide resolved
…sing glob in allowDefaultProject Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
…ice.test.ts Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
f780c1d
into
typescript-eslint:main

PR Checklist
Overview
Use minimatch dot option to take file starting with a dot into account when configuring allowDefaultProject using globs