-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
Some RuleTester tests in this repo are generated dynamically. Auto-generating tests like that can help create comprehensive test coverage for rules - but:
- They tended to exponentially grow in size as more cases get grown
- This is especially bad for slow typed tests: e.g. Tests: Reduce the giant number of naming-convention tests #9691
- They make it hard to see what cases are or aren't being tested
- They're not very statically analyzable
We'd like to move away from these auto-generated / dynamic test cases. That specifically means making all test cases passed to RuleTester be completely inline plain old JavaScript objects. No .flatMaps/.maps, no dedupeTestCases, helper functions, etc.
This issue tracks doing so for packages/eslint-plugin/tests/rules/no-base-to-string.test.ts.
Additional Info
💖
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs