TwemojiParser: Switch to defaulting to 'v/latest' URLs from MaxCDN

Nathan Downs · Nathan Downs · commit 4ac567db6fd3 · 2019-11-13T17:06:06.000-08:00
**Problem**
The `twemoji-parser` project defaults emoji urls to their old `/2/` paths on MaxCDN

**Solution**
Use `/v/latest/` as the default for parsed emoji urls on MaxCDN
diff --git a/README.md b/README.md
@@ -20,13 +20,13 @@ const entities = parse('I 🧡 Twemoji! 🥳');
 /*
 entities = [
   {
-    url: 'https://twemoji.maxcdn.com/2/svg/1f9e1.svg',
+    url: 'https://twemoji.maxcdn.com/v/latest/svg/1f9e1.svg',
     indices: [ 2, 4 ],
     text: '🧡',
     type: 'emoji'
   },
   {
-    url: 'https://twemoji.maxcdn.com/2/svg/1f973.svg',
+    url: 'https://twemoji.maxcdn.com/v/latest/svg/1f973.svg',
     indices: [ 12, 14 ],
     text: '🥳',
     type: 'emoji'
diff --git a/src/__tests__/index.test.js b/src/__tests__/index.test.js
@@ -98,23 +98,23 @@ describe('parse', () => {
     test('use MaxCDN SVGs by default', () => {
       expect(parse('I \u2764 emoji!')).toMatchObject([
         {
-          url: 'https://twemoji.maxcdn.com/2/svg/2764.svg'
+          url: 'https://twemoji.maxcdn.com/v/latest/svg/2764.svg'
         }
       ]);
     });
 
     test('can ask for MaxCDN PNGs', () => {
       expect(parse('I \u2764 emoji!', { assetType: 'png' })).toMatchObject([
         {
-          url: 'https://twemoji.maxcdn.com/2/72x72/2764.png'
+          url: 'https://twemoji.maxcdn.com/v/latest/72x72/2764.png'
         }
       ]);
     });
 
-    test('unrecognized assetType defaults back to SVG', () => {
-      expect(parse('I \u2764 emoji!', { assetType: 'svg' })).toMatchObject([
+    test('non-png assetType defaults back to SVG', () => {
+      expect(parse('I \u2764 emoji!', { assetType: 'foobar' })).toMatchObject([
         {
-          url: 'https://twemoji.maxcdn.com/2/svg/2764.svg'
+          url: 'https://twemoji.maxcdn.com/v/latest/svg/2764.svg'
         }
       ]);
     });
diff --git a/src/index.js b/src/index.js
@@ -24,8 +24,8 @@ export function parse(text: string, options?: ParsingOptions): Array<EmojiEntity
       ? options.buildUrl
       : (codepoints, assetType) =>
           assetType === 'png'
-            ? `https://twemoji.maxcdn.com/2/72x72/${codepoints}.png`
-            : `https://twemoji.maxcdn.com/2/svg/${codepoints}.svg`;
+            ? `https://twemoji.maxcdn.com/v/latest/72x72/${codepoints}.png`
+            : `https://twemoji.maxcdn.com/v/latest/svg/${codepoints}.svg`;
 
   const entities = [];
 

Original file line number	Diff line number	Diff line change
`@@ -98,23 +98,23 @@ describe('parse', () => {`
`98`	`98`	`test('use MaxCDN SVGs by default', () => {`
`99`	`99`	`expect(parse('I \u2764 emoji!')).toMatchObject([`
`100`	`100`	`{`
`101`		`- url: 'https://twemoji.maxcdn.com/2/svg/2764.svg'`
	`101`	`+ url: 'https://twemoji.maxcdn.com/v/latest/svg/2764.svg'`
`102`	`102`	`}`
`103`	`103`	`]);`
`104`	`104`	`});`
`105`	`105`
`106`	`106`	`test('can ask for MaxCDN PNGs', () => {`
`107`	`107`	`expect(parse('I \u2764 emoji!', { assetType: 'png' })).toMatchObject([`
`108`	`108`	`{`
`109`		`- url: 'https://twemoji.maxcdn.com/2/72x72/2764.png'`
	`109`	`+ url: 'https://twemoji.maxcdn.com/v/latest/72x72/2764.png'`
`110`	`110`	`}`
`111`	`111`	`]);`
`112`	`112`	`});`
`113`	`113`
`114`		`- test('unrecognized assetType defaults back to SVG', () => {`
`115`		`- expect(parse('I \u2764 emoji!', { assetType: 'svg' })).toMatchObject([`
	`114`	`+ test('non-png assetType defaults back to SVG', () => {`
	`115`	`+ expect(parse('I \u2764 emoji!', { assetType: 'foobar' })).toMatchObject([`
`116`	`116`	`{`
`117`		`- url: 'https://twemoji.maxcdn.com/2/svg/2764.svg'`
	`117`	`+ url: 'https://twemoji.maxcdn.com/v/latest/svg/2764.svg'`
`118`	`118`	`}`
`119`	`119`	`]);`
`120`	`120`	`});`