feat: Support retain_backups_on_delete for postgres #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Adding Oscar as co-author since this is direct copy/paste from their mysql changes Inspiration from: Oscar van Leusen <oscar.vanleusen@pexip.com> (Could not add as co-authored-by due to Google CLA not agreeing for some weird reason)
Contributor
|
LGTM (but also I am not a Googler, so that doesn't mean that much) |
Collaborator
|
gcbrun |
Collaborator
|
/gcbrun |
imrannayer
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiration (e.g. direct copy/paste) from the work of @OscarVanL on #735
I tried to use
Co-authored-byon the commit, however the CLA check did not recognize Oscar, even thought I used the exact username/email combination that exists in other commits. Either way, thanks @OscarVanL !This would be nice for us since we're using the postgres module for some of our databases in Instruqt.
Relates: #735
Tests
make generate_docs