Skip to content

fix: truncate service account display_name in backup module #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

fix: truncate service account display_name in backup module #734

merged 2 commits into from
May 21, 2025

Conversation

@OscarVanL
Copy link
Contributor

@OscarVanL OscarVanL commented May 21, 2025

Fixes #733

My database name is 35 characters long. The Managed by Terraform - Service account for backup of SQL Instance string is 66 characters long. In total this makes 101 characters, which fails the validation check to create the service account:

Error: Error creating service account: googleapi: Error 400: The display_name length (101) is longer than the maximum allowed length 100., badRequest
  with module.cloudsql_backup[0].google_service_account.sql_backup_serviceaccount[0],
  on .terraform/modules/cloudsql_backup/modules/backup/main.tf line 33, in resource "google_service_account" "sql_backup_serviceaccount":
  33: resource "google_service_account" "sql_backup_serviceaccount" {

This change will truncate the display_name if it exceeds 100 characters.

@OscarVanL
Truncate the display_name to 100 characters to ensure the service acc…
10bc4bd 
…ount can be created successfully if the SQL instance name is long
@OscarVanL OscarVanL requested review from a team, ayushmjain, imrannayer and q2w as code owners May 21, 2025 13:22
@imrannayer
Copy link
Collaborator

imrannayer commented May 21, 2025

/gcbrun

@OscarVanL
Copy link
Contributor Author

OscarVanL commented May 21, 2025 •
edited
Loading

@imrannayer Thanks for running the tests. What are your thoughts on this, is it ok?

@imrannayer imrannayer merged commit edc7ee7 into terraform-google-modules:main May 21, 2025
4 checks passed
@release-please release-please bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imrannayer imrannayer imrannayer approved these changes

@ayushmjain ayushmjain Awaiting requested review from ayushmjain ayushmjain is a code owner

@q2w q2w Awaiting requested review from q2w q2w is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Backups module generates service account with display name that is too long (>100 chars)

2 participants

@OscarVanL @imrannayer