fix: replace invalid optional(string, ) with optional(string) #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@steamedEggMaster thx for the PR. can u plz sign CLA? |
Contributor
Author
|
@imrannayer I’ve signed the CLA. Let me know if anything else is needed. Thanks! |
Collaborator
|
waiting on fix #726 merge |
Collaborator
|
/gcbrun |
3 similar comments
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
imrannayer
approved these changes
Apr 24, 2025
056e436
into
terraform-google-modules:main
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replaced all instances of
optional(string, )withoptional(string, null)across thepostgresqlandmysqlmodules.Why
While the syntax
optional(string, )does not currently cause errors in Terraform and works as expected, it is not officially valid HCL. The presence of the trailing comma can cause confusion for contributors or users reading the code, especially those unfamiliar with how Terraform interprets it.This change aims to improve clarity and avoid potential misunderstandings, without introducing any functional changes.
Testing
All modules passed validation:
terraform init && terraform validate