Skip to content

fix: Disable SQL instance data_cache when data_cache_enabled variable is false #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

fix: Disable SQL instance data_cache when data_cache_enabled variable is false #720

merged 4 commits into from
Apr 17, 2025

Conversation

@diablo02000
Copy link
Contributor

@diablo02000 diablo02000 commented Apr 10, 2025

When var.data_cache_enabled is set to false, the dynamic block data_cache_config is ignored. Exemple with mysql module:

for_each = var.edition == "ENTERPRISE_PLUS" && var.data_cache_enabled ? ["cache_enabled"] : []

Due to this, the default value on GCP Cloud SQL, which is true, is applied.

Example:

  • Create Cloud SQL instance:
gcloud sql instances create mysql-testing-instance --region europe-west1 --tier 'db-perf-optimized-N-2' --project-id sbx --database-version 'MYSQL_8_0' --edition ENTERPRISE_PLUS
  • Check the data cache value:
gcloud sql instances describe mysql-testing-instance --project sbx | grep -A 2 dataCacheConfig

  dataCacheConfig:
    dataCacheEnabled: true
  dataDiskSizeGb: '10'

@diablo02000 diablo02000 requested review from a team, ayushmjain, imrannayer and q2w as code owners April 10, 2025 14:23
@google-cla
Copy link

google-cla bot commented Apr 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer
Copy link
Collaborator

imrannayer commented Apr 10, 2025

/gcbrun

2 similar comments
@imrannayer
Copy link
Collaborator

imrannayer commented Apr 14, 2025

/gcbrun

@imrannayer
Copy link
Collaborator

imrannayer commented Apr 15, 2025

/gcbrun

@imrannayer
Copy link
Collaborator

imrannayer commented Apr 15, 2025

/gcbrun

1 similar comment
@imrannayer
Copy link
Collaborator

imrannayer commented Apr 16, 2025

/gcbrun

@imrannayer imrannayer merged commit 7befe54 into terraform-google-modules:main Apr 17, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imrannayer imrannayer imrannayer approved these changes

@ayushmjain ayushmjain Awaiting requested review from ayushmjain ayushmjain is a code owner

@q2w q2w Awaiting requested review from q2w q2w is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diablo02000 @imrannayer @christophe-biguereau-believe