-
Notifications
You must be signed in to change notification settings - Fork 473
feat: Add reuse_interval to password validation policy configuration #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add reuse_interval to password validation policy configuration #687
Conversation
|
friendly ping, Could you review? @imrannayer @q2w |
modules/mysql/variables.tf
Outdated
| min_length = number | ||
| complexity = string | ||
| disallow_username_substring = bool | ||
| reuse_interval = number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anluuhoai if it is not required can u make it optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is already an option. If you don't fill it in, it will be null. In this case, I need to config the reuse_interval, but the current module doesn't have this option.
In the console, if you fill in the reuse interval, when I run this module without reuse_interval, it will remove the reuse interval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any update? @imrannayer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anluuhoai if this is not required can u plz define as optional
reuse_interval = optional(number)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think reuse_interval is no different from min_length or complexity @imrannayer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I updated.
|
/gcbrun |
|
@anluuhoai can you plz lint test? |
|
Updated. Please re-run. @imrannayer |
|
/gcbrun |
No description provided.