Skip to content

Conversation

@anluuhoai
Copy link
Contributor

No description provided.

@anluuhoai
Copy link
Contributor Author

friendly ping, Could you review? @imrannayer @q2w

min_length = number
complexity = string
disallow_username_substring = bool
reuse_interval = number
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anluuhoai if it is not required can u make it optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already an option. If you don't fill it in, it will be null. In this case, I need to config the reuse_interval, but the current module doesn't have this option.
In the console, if you fill in the reuse interval, when I run this module without reuse_interval, it will remove the reuse interval.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update? @imrannayer

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anluuhoai if this is not required can u plz define as optional

reuse_interval = optional(number)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reuse_interval is no different from min_length or complexity @imrannayer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I updated.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

@anluuhoai can you plz lint test?

@anluuhoai
Copy link
Contributor Author

Updated. Please re-run. @imrannayer

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit c3885a5 into terraform-google-modules:main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants