feat: context.resolve now returns string #2507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import.meta.resolve on node and browser returns a string - update implemenation of createContext to match. BREAKING CHANGE: runtime behavior of import.meta.resolve changes from async to sync
File size impactMerging feature/breaking-context into main will impact 3 files in 2 groups. browser (2/2)
node (1/1)
extras (0/8)No impact on files in extras group. |
Author
|
Not source compatible since value is not thenable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import.meta.resolve on node and browser returns a string - update implementation of createContext to match.
Runtime behavior of existing code should continue to work
old behavior
new behavior
Runtime behavior may be backward compatible since awaiting a string results in a string.
Note that types for Node already reflect the new behavior.
BREAKING CHANGE: runtime behavior of import.meta.resolve changes from async to sync