[Security] Allow multiple OIDC discovery endpoints #62043
Merged
+287
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13696f9 to
c6bcc32
Compare
fabpot
requested changes
Oct 13, 2025
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
c6bcc32 to
50c135a
Compare
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Do we want to keep synchronous HTTP calls? Shouldn't we do concurrent ones?
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
Contributor
Author
I like it, will check it out! Thanks for the review 🙏 |
Contributor
Author
But how to do that, in combination with the Symfony Cache callbacks? They have their own cache, so they could also be evicted separately etc. |
783e73c to
102be5e
Compare
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Do we want to keep synchronous HTTP calls? Shouldn't we do concurrent ones?
But how to do that, in combination with the Symfony Cache callbacks?
They have their own cache, so they could also be evicted separately etc.
Let's have a single cache entry. I don't see the need for many 🤷
...le/Tests/DependencyInjection/Fixtures/php/access_token_oidc_user_info_multiple_discovery.php
Outdated
Show resolved
Hide resolved
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
6f4ee9c to
bbecc4d
Compare
ruudk
commented
Oct 13, 2025
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Outdated
Show resolved
Hide resolved
ruudk
commented
Oct 13, 2025
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
ruudk
commented
Oct 13, 2025
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Oct 13, 2025
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Some minor tweaks then LGTM, thanks.
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
Member
|
(well, please check tests before :) |
Contributor
Author
|
Alright, it's ready ! |
Spomky
approved these changes
Oct 14, 2025
src/Symfony/Component/Security/Http/AccessToken/Oidc/OidcTokenHandler.php
Outdated
Show resolved
Hide resolved
...y/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcTokenHandlerFactory.php
Show resolved
Hide resolved
1aeb0d8 to
bc7424f
Compare
Member
|
Thank you @ruudk. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a firewall accepts tokens from multiple identity providers, it needs to validate tokens against different OIDC discovery endpoints. This change allows configuring multiple named discovery servers instead of just one, while keeping backward compatibility.
With this change, we allow configuring multiple discovery endpoints with different (or the same) cache storage. They all use a different cache key.
It then builds a JWTSet of all the keys fetched, from the multiple endpoints, and then validates the JWT against that total JWTSet.
/cc @vincentchalamon @Jean-Beru @chalasr @Spomky Tagging you as you were all involved in previous OIDC PR's. Curious to hear your opinions about this 🙏