[Security] Deprecate PersistentToken::getClass() and RememberMeDetails::getUserFqcn() in order to remove the user FQCN from the remember-me cookie in 8.0
#61654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e8e2d5 to
53cdf23
Compare
src/Symfony/Component/Security/Core/Authentication/RememberMe/PersistentToken.php
Show resolved
Hide resolved
53cdf23 to
d2d53fe
Compare
…ails::getUserFqcn()` in order to remove the user FQCN from the remember-me cookie in 8.0
d2d53fe to
5c07c91
Compare
alexandre-daubois
approved these changes
Sep 9, 2025
chalasr
approved these changes
Sep 10, 2025
fabpot
approved these changes
Sep 10, 2025
Member
|
Thank you @nicolas-grekas. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 15, 2025
…tToken` and `RememberMeDetails` (xabbuh) This PR was merged into the 7.4 branch. Discussion ---------- [Security] deprecate the FQCN properties of `PersistentToken` and `RememberMeDetails` | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | | License | MIT while cleaning up the `8.0` branch from the deprecations introduced in #61654 I wondered if we shouldn't also deprecate passing the user FQCN to `PersistentToken` and `RememberMeDetails` in the first place Commits ------- 0e733fd deprecate the FQCN properties of PersistentToken and RememberMeDetails
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #59232
Having the user FQCN in the remember-me cookie leaks internal details that are not needed.
In the end
userProvider->loadUserByIdentifier()is called, so that there's not need to early-exclude a cookie that's otherwise valid - and that's the only practical use case.