bug #62153 [HttpFoundation] Fix issue where ServerEvent with "0" data is not sent (santysisi)

nicolas-grekas · nicolas-grekas · commit 42bad65ab56b · 2025-10-25T13:29:58.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [HttpFoundation] Fix issue where ServerEvent with "0" data is not sent | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62151 | License | MIT Fixes an issue where data with a string value of '0' was not being sent correctly. This update ensures that the '0' string is handled properly when sending data. Commits ------- b81271e [HttpFoundation] Fix issue where ServerEvent with "0" data is not sent
diff --git a/src/Symfony/Component/HttpFoundation/ServerEvent.php b/src/Symfony/Component/HttpFoundation/ServerEvent.php
@@ -132,14 +132,12 @@ public function getIterator(): \Traversable
         }
         yield $head;
 
-        if ($this->data) {
-            if (is_iterable($this->data)) {
-                foreach ($this->data as $data) {
-                    yield \sprintf('data: %s', $data)."\n";
-                }
-            } else {
-                yield \sprintf('data: %s', $this->data)."\n";
+        if (is_iterable($this->data)) {
+            foreach ($this->data as $data) {
+                yield \sprintf('data: %s', $data)."\n";
             }
+        } elseif ('' !== $this->data) {
+            yield \sprintf('data: %s', $this->data)."\n";
         }
 
         yield "\n";
diff --git a/src/Symfony/Component/HttpFoundation/Tests/EventStreamResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/EventStreamResponseTest.php
@@ -116,6 +116,28 @@ public function testStreamEventWithSendMethod()
         $this->assertSameResponseContent("data: foo\n\n", $response);
     }
 
+    public function testStreamEventWith0Data()
+    {
+        $response = new EventStreamResponse(function () {
+            yield new ServerEvent(
+                data: '0',
+            );
+        });
+
+        $this->assertSameResponseContent("data: 0\n\n", $response);
+    }
+
+    public function testStreamEventEmptyStringIgnored()
+    {
+        $response = new EventStreamResponse(function () {
+            yield new ServerEvent(
+                data: '',
+            );
+        });
+
+        $this->assertSameResponseContent("\n", $response);
+    }
+
     private function assertSameResponseContent(string $expected, EventStreamResponse $response): void
     {
         ob_start();

Original file line number	Diff line number	Diff line change
`@@ -132,14 +132,12 @@ public function getIterator(): \Traversable`
`132`	`132`	`}`
`133`	`133`	`yield $head;`
`134`	`134`
`135`		`- if ($this->data) {`
`136`		`- if (is_iterable($this->data)) {`
`137`		`- foreach ($this->data as $data) {`
`138`		`- yield \sprintf('data: %s', $data)."\n";`
`139`		`- }`
`140`		`- } else {`
`141`		`- yield \sprintf('data: %s', $this->data)."\n";`
	`135`	`+ if (is_iterable($this->data)) {`
	`136`	`+ foreach ($this->data as $data) {`
	`137`	`+ yield \sprintf('data: %s', $data)."\n";`
`142`	`138`	`}`
	`139`	`+ } elseif ('' !== $this->data) {`
	`140`	`+ yield \sprintf('data: %s', $this->data)."\n";`
`143`	`141`	`}`
`144`	`142`
`145`	`143`	`yield "\n";`