fix: correct parent component link for web components #7069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nesting web components, the parent component link is currently not set up correctly. With this change, every parent node will be checked for having the SvelteElement constructor in its prototype chain. This can likely be optimized further by checking for the $$ component first.
lloydzhou
reviewed
Sep 11, 2022
| return component; | ||
| } | ||
|
|
||
| export function init(component, options, instance, create_fragment, not_equal, props, append_styles, dirty = [-1]) { |
There was a problem hiding this comment.
"init" function call in constructor of SvelteElement, can not get parentNode, so this PR can not fix the issue.
you can get parentNode in connectedCallback.
Member
|
With #8457 this will be reworked, and it then will be possible to nest regular Svelte components within a Svelte custom element, which should fix the use cases for this. I think it would be a mistake to try to do special things for custom elements that happen to be written in Svelte - custom elements should have as much interoperability as possible and what library they were written in should be an implementation detail. Therefore closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for fixing the parent component link for nested web components, e.g. when using
we want the child to have a parent component link set appropriately, so that e.g. the context API (see #3422) works correctly. The test itself is a bit rough and likely can be optimized by checking for the $$ property first, but I'd like to get idea out first.