Skip to content

Conversation

@PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented May 9, 2024

It was pointed out in discord that "Introducing Runes" post doesn't specify .svelte.js/ts suffix, hence this fixes that.

Also ad file names to the counter example, so first example shows counter.js, after the diff it shoes counter.svelte.js

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 06046a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


This works, but it's pretty weird! We've found that the store API can get rather unwieldy when you start doing more complex things.

With runes, things get much simpler:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to mention .svelte.js in prose, it should be somewhere around here instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

PuruVJ and others added 2 commits May 9, 2024 22:10
Co-authored-by: Rich Harris <rich.harris@vercel.com>
</button>
```

> Runes can only be used in `.svelte.js` and `.svelte.ts` files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of Rich's (and my) suggestion here was that we should also mention .svelte files. It's confusing to say runes only work in .svelte.js and .svelte.ts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the new language? I didn't wanna put .svelte, '.svelte.js' and .svelte.ts all together, too many svelte's

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It's already implied it works in .svelte files)

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants