Skip to content

Conversation

@raymondwang
Copy link

Obviously really minor, but I'm running through the docs for the first time and thought I'd add these guys to help make the TypeScript code examples more consistent. They're a nice touch!

Before After
Screenshot 2024-04-03 at 10 07 09 PM Screenshot 2024-04-03 at 10 07 30 PM

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: da2b83b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

IIRC we had this in a previous version but then decided against it because it takes too much screen real estate in relation to what it brings

@raymondwang
Copy link
Author

It's applied inconsistently right now; some examples have TypeScript annotations, and these don't. I don't have a horse in this race, but I figured it would be easy enough to be consistent here.

@raymondwang
Copy link
Author

I thought this was just a nice little detail so I threw the change up — if we're moving away from the TS code syntax switcher in the docs, I'm happy to close this issue out. Appreciate the consideration 👍

@dummdidumm
Copy link
Member

dummdidumm commented Apr 6, 2024

Apologies - this isn't just about having the file header it's about the code now being able to switch between js and ts . Makes sense!

@raymondwang
Copy link
Author

ha, that makes sense; sorry I wasn't clear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants