-
Notifications
You must be signed in to change notification settings - Fork 27
Open
Description
I created types for the serverless-step-functions plugin and submitted it to DefinitelyTyped PR#66693.
The @types/serverless-step-functions depend on this package, because it uses module augmentation to merge the StepFunctions types into the Serverless type.
However, the CI on the PR fails due to errors in this package:
Test Log

The mentioned lines of code node_modules/@serverless/typescript/index.d.ts(1348,7) are these:
Lines 1360 to 1390 in 29ea18f
| Resources?: { | |
| "Fn::Transform"?: { | |
| Name: string; | |
| Parameters?: { | |
| [k: string]: unknown; | |
| }; | |
| }; | |
| /** | |
| * This interface was referenced by `undefined`'s JSON-Schema definition | |
| * via the `patternProperty` "^[a-zA-Z0-9]{1,255}$". | |
| */ | |
| [k: string]: { | |
| Type: string; | |
| Properties?: { | |
| [k: string]: unknown; | |
| }; | |
| CreationPolicy?: { | |
| [k: string]: unknown; | |
| }; | |
| DeletionPolicy?: string; | |
| DependsOn?: AwsResourceDependsOn; | |
| Metadata?: { | |
| [k: string]: unknown; | |
| }; | |
| UpdatePolicy?: { | |
| [k: string]: unknown; | |
| }; | |
| UpdateReplacePolicy?: string; | |
| Condition?: AwsResourceCondition; | |
| }; | |
| }; |
The property "Fn::Transform"?: can be undefined while the index type [k: string]: can't be undefined. I assume changing it to [k: string]?: would be enough to fix it?
aardvarkk, polyomino24, adambiggs, DavidVaness and dev99problems
Metadata
Metadata
Assignees
Labels
No labels