[code-quality] Add VariableConstFetchToClassConstFetchRector #7457
+344
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c5b838 to
c6de4a5
Compare
481eee4 to
4cc11c6
Compare
samsonasik
reviewed
Oct 10, 2025
rules/CodeQuality/Rector/ClassConstFetch/VariableConstFetchToClassConstFetchRector.php
Outdated
Show resolved
Hide resolved
4cc11c6 to
36b2cf4
Compare
samsonasik
reviewed
Oct 11, 2025
| */ | ||
| public function refactor(Node $node): ?ClassConstFetch | ||
| { | ||
| if (! $node->class instanceof Expr) { |
Member
There was a problem hiding this comment.
per rule name, I think this needs to be exactly check against Variable node, check on Expr may cause invalid due to side effect call, eg:
some_side_effect()::NAME;I will create new PR to fix it.
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer known class, over pseudo-dynamic value:
final class AllowOverride { public function run(KnownClass $classWithConstants) { - return $classWithConstants::SOME_CONSTANT; + return KnownClass::SOME_CONSTANT; } }