Add AddAllowDynamicPropertiesAttribute to php82 set #3311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This would turn every class into dynamic one, without any explicit need. I'm sorry, but we won't merge this. See #1225 (comment) |
Contributor
Author
|
Thanks for ponting me at the comment! Somehow I had already liked this a yeae ago 😅 |
Contributor
Author
|
Maybe there should be a link under the 8.2 section though to make clear that the rule does exist? @TomasVotruba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AddAllowDynamicPropertiesAttribute to the PHP 8.2 set list as it is needed in lots of legacy applications for a php8.2 upgrade.
It might not be the sexiest solution as some projects might not need it and especially not all classes, but it is the least risky method I think.
I also added a link on the rules overview.