skip all-typed properties in TypedPropertyFromStrictConstructorRector

TomasVotruba · TomasVotruba · commit c5d9fdfcbe5b · 2025-10-27T10:59:31.000+01:00
diff --git a/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php b/rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php
@@ -93,7 +93,11 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         $constructClassMethod = $node->getMethod(MethodName::CONSTRUCT);
-        if (! $constructClassMethod instanceof ClassMethod || $node->getProperties() === []) {
+        if (! $constructClassMethod instanceof ClassMethod) {
+            return null;
+        }
+
+        if (! $this->hasSomeUntypedProperties($node)) {
             return null;
         }
 
@@ -180,4 +184,17 @@ private function shouldSkipPropertyType(Type $propertyType): bool
 
         return $this->doctrineTypeAnalyzer->isInstanceOfCollectionType($propertyType);
     }
+
+    private function hasSomeUntypedProperties(Node|Class_ $node): bool
+    {
+        foreach ($node->getProperties() as $property) {
+            if ($property->type instanceof \PhpParser\Node) {
+                continue;
+            }
+
+            return true;
+        }
+
+        return false;
+    }
 }
