skip refernce one as well in /TypedPropertyFromJMSSerializerAttributeTypeRector

TomasVotruba · TomasVotruba · commit 842aa94d34c9 · 2025-10-28T15:08:23.000+01:00
diff --git a/rules-tests/TypeDeclaration/Rector/Class_/TypedPropertyFromJMSSerializerAttributeTypeRector/Fixture/skip_to_many.php.inc b/rules-tests/TypeDeclaration/Rector/Class_/TypedPropertyFromJMSSerializerAttributeTypeRector/Fixture/skip_to_many.php.inc
@@ -6,9 +6,13 @@ use JMS\Serializer\Annotation\Type;
 use Rector\Tests\TypeDeclaration\Rector\Class_\TypedPropertyFromJMSSerializerAttributeTypeRector\Source\SomeClassInSerializer;
 use Doctrine\ODM\MongoDB\Mapping\Annotations as MongoDB;
 
-final class SkipToMany
+final class SkipToManyAndToOne
 {
     #[Type(SomeClassInSerializer::class)]
     #[MongoDB\EmbedMany(targetDocument: SomeClassInSerializer::class)]
     private $someClasses;
+
+    #[Type('string')]
+    #[MongoDB\ReferenceOne(targetDocument: SomeClassInSerializer::class)]
+    private $someObject;
 }
diff --git a/rules/TypeDeclaration/Rector/Class_/TypedPropertyFromJMSSerializerAttributeTypeRector.php b/rules/TypeDeclaration/Rector/Class_/TypedPropertyFromJMSSerializerAttributeTypeRector.php
@@ -105,7 +105,7 @@ public function refactor(Node $node): ?Node
             }
 
             // this will be most likely collection, not single type
-            if ($this->phpAttributeAnalyzer->hasPhpAttributes($property, CollectionMapping::TO_MANY_CLASSES)) {
+            if ($this->phpAttributeAnalyzer->hasPhpAttributes($property, array_merge(CollectionMapping::TO_MANY_CLASSES, CollectionMapping::TO_ONE_CLASSES))) {
                 continue;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,13 @@ use JMS\Serializer\Annotation\Type;`
`6`	`6`	`use Rector\Tests\TypeDeclaration\Rector\Class_\TypedPropertyFromJMSSerializerAttributeTypeRector\Source\SomeClassInSerializer;`
`7`	`7`	`use Doctrine\ODM\MongoDB\Mapping\Annotations as MongoDB;`
`8`	`8`
`9`		`-final class SkipToMany`
	`9`	`+final class SkipToManyAndToOne`
`10`	`10`	`{`
`11`	`11`	`#[Type(SomeClassInSerializer::class)]`
`12`	`12`	`#[MongoDB\EmbedMany(targetDocument: SomeClassInSerializer::class)]`
`13`	`13`	`private $someClasses;`
	`14`	`+`
	`15`	`+ #[Type('string')]`
	`16`	`+ #[MongoDB\ReferenceOne(targetDocument: SomeClassInSerializer::class)]`
	`17`	`+ private $someObject;`
`14`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public function refactor(Node $node): ?Node`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`// this will be most likely collection, not single type`
`108`		`- if ($this->phpAttributeAnalyzer->hasPhpAttributes($property, CollectionMapping::TO_MANY_CLASSES)) {`
	`108`	`+ if ($this->phpAttributeAnalyzer->hasPhpAttributes($property, array_merge(CollectionMapping::TO_MANY_CLASSES, CollectionMapping::TO_ONE_CLASSES))) {`
`109`	`109`	`continue;`
`110`	`110`	`}`
`111`	`111`