Skip to content

fix event loop is closed #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 11, 2025
Merged

fix event loop is closed #5030

merged 12 commits into from
Nov 11, 2025
+435 −23

Conversation

@codomposer
Copy link
Contributor

@codomposer codomposer commented Oct 30, 2025 •
edited by Bibo-Joshi
Loading

Fixes

Closes #5021

Check-list for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage) - N/A

  • New Classes

    • Added self._id_attrs and corresponding documentation
    • init accepts api_kwargs as keyword-only

  • Added New Shortcuts

    • In telegram.Chat & telegram.User for all methods that accept chat/user_id
    • In telegram.Message for all methods that accept chat_id and message_id
    • For new telegram.Message shortcuts: Added quote argument if methods accept reply_to_message_id
    • In telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If Relevant

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Linked new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added new message types to telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst (including the badge) and telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

Contribution by Gittensor, learn more at https://gittensor.io/

Bibo-Joshi
Bibo-Joshi requested changes Nov 3, 2025
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR!
I've left some comments. In addition to that, we'll need new unit tests that cover the changes. If you need some pointers on where to get started, please let me know.

@codomposer codomposer requested a review from Bibo-Joshi November 3, 2025 14:49
Bibo-Joshi
Bibo-Joshi requested changes Nov 4, 2025
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I've left some new comments below. Please let me know in case you have any questions on them. In addition

bugfixes = "Fix a Bug in Initialization Logic of ``Bot``"
[[pull_requests]]
uid = "5030"
author_uids = ["codomposer"]
closes_threads = ["5021"]

@codomposer codomposer requested a review from Bibo-Joshi November 4, 2025 19:59
@codomposer
Copy link
Contributor Author

codomposer commented Nov 6, 2025

@Bibo-Joshi
can you please check this PR again?

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Nov 6, 2025

@codomposer Hey. I will come back to this, when I have the time and mental capacity for it, yes.

Bibo-Joshi
Bibo-Joshi requested changes Nov 8, 2025
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I've just 2 small comments open. Thanks very much for the updates and sorry for the delay in review - busy week …

@codomposer
Copy link
Contributor Author

codomposer commented Nov 10, 2025

Hi. I've just 2 small comments open. Thanks very much for the updates and sorry for the delay in review - busy week …

comments addressed, can you please check it? @Bibo-Joshi

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Nov 11, 2025

Hi. Unfortunately, the if-clause is still not correctly covered. Please use pytest-cov locally to compute the coverage and verify that the case is covered. If you need help with that, please reach out. This week, I'm unlikely to have to to dig into that myself …

@codomposer
Copy link
Contributor Author

codomposer commented Nov 11, 2025

Hi. Unfortunately, the if-clause is still not correctly covered. Please use pytest-cov locally to compute the coverage and verify that the case is covered. If you need help with that, please reach out. This week, I'm unlikely to have to to dig into that myself …

@Bibo-Joshi
I've pushed update to cover test_initialize_with_bot_already_initialized_but_not_requests,
can you comment under codeblocks that are missing test coverage if any?
thanks

@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Nov 11, 2025

Ah, I see my mistake now: get_me can only be called if the request init already succeeded and only then can _bot_initialized become True. This means that we simply don't need the if not self._bot_initialized check. In the test this shows because you can only catch the current edge case by adapting the internals of Bot, not by mocking the methods called by Bot.init.
TL;DR: please revert your last commit and instead remove the mentioned if-clause. Please excuse the confusion.

@codomposer
Copy link
Contributor Author

codomposer commented Nov 11, 2025

Ah, I see my mistake now: get_me can only be called if the request init already succeeded and only then can _bot_initialized become True. This means that we simply don't need the if not self._bot_initialized check. In the test this shows because you can only catch the current edge case by adapting the internals of Bot, not by mocking the methods called by Bot.init. TL;DR: please revert your last commit and instead remove the mentioned if-clause. Please excuse the confusion.

done

@Bibo-Joshi Bibo-Joshi merged commit 98d9908 into python-telegram-bot:master Nov 11, 2025
49 of 57 checks passed
@Bibo-Joshi
Copy link
Member

Bibo-Joshi commented Nov 11, 2025

Thank you very much for your contribution, and also for your patience in the review process! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bibo-Joshi Bibo-Joshi Awaiting requested review from Bibo-Joshi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RuntimeError: Event loop is closed

2 participants

@codomposer @Bibo-Joshi