fix(glpiselectfield): cannot set empty value by default for entity question

btry · btry · commit fe2130bbecf4 · 2022-12-12T12:43:37.000+01:00
diff --git a/inc/field/dropdownfield.class.php b/inc/field/dropdownfield.class.php
@@ -340,7 +340,7 @@ public function buildParams($rand = null) {
       if ($itemtype != Entity::class) {
          $dparams['display_emptychoice'] = ($this->question->fields['show_empty'] !== '0');
       } else {
-         if ($this->question->fields['show_empty'] !== '0') {
+         if ($this->question->fields['show_empty'] != '0') {
             $dparams['toadd'] = [
                -1 => Dropdown::EMPTY_VALUE,
             ];
diff --git a/templates/field/glpiselectfield.html.twig b/templates/field/glpiselectfield.html.twig
@@ -62,13 +62,21 @@
     ) }}
 
     {% if item.fields['itemtype'] is defined and item.fields['itemtype'] != '0' %}
+        {% set to_add = {} %}
+        {% if item.fields['itemtype'] == 'Entity' %}
+            {% set default_values = item.fields['default_values'] == '' ? -1 : item.fields['default_values'] %}
+            {% set to_add = {
+                '-1': constant('Dropdown::EMPTY_VALUE'),
+            } %}
+        {% endif %}
         {{ fields.dropdownField(
             item.fields['itemtype'],
             'default_values',
-            item.fields['default_values'],
+            default_values,
             __('Default values'), {
                 label_class: 'col-xxl-4',
                 input_class: 'col-xxl-8',
+                toadd: to_add,
             }
         ) }}
     {% else %}
