fix(dropdownfield): incomplete group restriction

btry · btry · commit eebcc21f1560 · 2024-02-19T10:21:01.000+01:00
diff --git a/inc/field/dropdownfield.class.php b/inc/field/dropdownfield.class.php
@@ -594,8 +594,9 @@ private function getMyGroups($userID) {
       if ($result->count() === 0) {
          return [];
       }
+      $a_groups = [];
       foreach ($result as $data) {
-         $a_groups                     = $dbUtil->getAncestorsOf("glpi_groups", $data["groups_id"]);
+         $a_groups                     = $a_groups + $dbUtil->getAncestorsOf("glpi_groups", $data["groups_id"]);
          $a_groups[$data["groups_id"]] = $data["groups_id"];
       }
       return $a_groups;

Original file line number	Diff line number	Diff line change
`@@ -594,8 +594,9 @@ private function getMyGroups($userID) {`
`594`	`594`	`if ($result->count() === 0) {`
`595`	`595`	`return [];`
`596`	`596`	`}`
	`597`	`+ $a_groups = [];`
`597`	`598`	`foreach ($result as $data) {`
`598`		`- $a_groups = $dbUtil->getAncestorsOf("glpi_groups", $data["groups_id"]);`
	`599`	`+ $a_groups = $a_groups + $dbUtil->getAncestorsOf("glpi_groups", $data["groups_id"]);`
`599`	`600`	`$a_groups[$data["groups_id"]] = $data["groups_id"];`
`600`	`601`	`}`
`601`	`602`	`return $a_groups;`