fix(abstractitiltarget): multiple tag questions set but not displayed in designer

btry · btry · commit 90f2a95d8579 · 2023-01-06T10:46:39.000+01:00
diff --git a/inc/abstractitiltarget.class.php b/inc/abstractitiltarget.class.php
@@ -1112,7 +1112,7 @@ function change_tag_type() {
                'fieldtype' => ['tag'],
             ],
             '_tag_questions',
-            $this->fields['tag_questions'],
+            explode(',', $this->fields['tag_questions']),
             [
                'multiple' => true,
             ]
diff --git a/inc/question.class.php b/inc/question.class.php
@@ -1043,7 +1043,7 @@ public static function getQuestionsFromFormBySection($form, $crit = []) {
     * @param PluginFormcreatorForm $form
     * @param array $crit
     * @param string $name
-    * @param string $value
+    * @param string|array $value
     * @param array $options
     * @return string|int HTML output or random id
     */
@@ -1055,8 +1055,10 @@ public static function dropdownForForm($form, $crit, $name, $value = null, $opti
       $options = $options + [
          'display' => $options['display'] ?? true,
       ];
-      if ($value !== null) {
+      if (is_string($value)) {
          $options['value'] = $value;
+      } else if (is_array($value)) {
+         $options['values'] = $value;
       }
       $output = Dropdown::showFromArray($name, $items, $options);
 

Original file line number	Diff line number	Diff line change
`@@ -1112,7 +1112,7 @@ function change_tag_type() {`
`1112`	`1112`	`'fieldtype' => ['tag'],`
`1113`	`1113`	`],`
`1114`	`1114`	`'_tag_questions',`
`1115`		`- $this->fields['tag_questions'],`
	`1115`	`+ explode(',', $this->fields['tag_questions']),`
`1116`	`1116`	`[`
`1117`	`1117`	`'multiple' => true,`
`1118`	`1118`	`]`