fix(target_actor): duplication fails for some types

btry · btry · commit 1ff8a555f146 · 2024-04-24T15:49:06.000+02:00
diff --git a/inc/target_actor.class.php b/inc/target_actor.class.php
@@ -191,8 +191,11 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
             $input['actor_value'] = $question->getID();
             break;
 
-         case self::ACTOR_TYPE_PERSON:
          case self::ACTOR_TYPE_AUTHORS_SUPERVISOR:
+            $input['actor_value'] = 0;
+            break;
+
+         case self::ACTOR_TYPE_PERSON:
             $user = new User;
             $field = $idKey == 'id' ? 'id' : 'name';
             $users_id = plugin_formcreator_getFromDBByField($user, $field, $input['actor_value']);
@@ -278,12 +281,18 @@ public function export(bool $remove_uuid = false) : array {
          case self::ACTOR_TYPE_GROUP_FROM_OBJECT:
          case self::ACTOR_TYPE_TECH_GROUP_FROM_OBJECT :
             $question = new PluginFormcreatorQuestion;
-            if ($question->getFromDB($target_actor['actor_value'])) {
-               $target_actor['actor_value'] = $question->fields['uuid'];
+            $field = $idToRemove == 'uuid' ? 'id' : 'uuid';
+            $question->getFromDBByCrit([
+               $field => $target_actor['actor_value']
+            ]);
+            if (!$question->isNewItem()) {
+               $target_actor['actor_value'] = $idToRemove == 'uuid' ? $question->getID() : $question->fields['uuid'];
             }
             break;
-         case self::ACTOR_TYPE_PERSON:
          case self::ACTOR_TYPE_AUTHORS_SUPERVISOR:
+            $target_actor['actor_value'] = 0;
+            break;
+         case self::ACTOR_TYPE_PERSON:
             $user = new User;
             $field = $idToRemove == 'uuid' ? 'id' : 'completename';
             if ($user->getFromDB($target_actor['actor_value'])) {
