fix(selectfield): show contact field

btry · btry · commit 11c86b7c3b83 · 2023-05-09T15:44:13.000+02:00
diff --git a/inc/field/dropdownfield.class.php b/inc/field/dropdownfield.class.php
@@ -352,18 +352,6 @@ public function buildParams($rand = null) {
          }
       }
 
-      $emptyItem = new $itemtype();
-      $emptyItem->getEmpty();
-      if (isset($emptyItem->fields['serial'])) {
-         $dparams['displaywith'][] = 'serial';
-      }
-      if (isset($emptyItem->fields['otherserial'])) {
-         $dparams['displaywith'][] = 'otherserial';
-      }
-      if ($itemtype === Ticket::class && !array_search('id', $dparams['displaywith'])) {
-         $dparams['displaywith'][] = 'id';
-      }
-
       return $dparams;
    }
 
diff --git a/inc/field/glpiselectfield.class.php b/inc/field/glpiselectfield.class.php
@@ -134,6 +134,28 @@ public function getAvailableValues(): array {
       return [];
    }
 
+   public function buildParams($rand = null) {
+      $dparams = parent::buildParams($rand);
+      $itemtype = $this->getSubItemtype();
+
+      $emptyItem = new $itemtype();
+      $emptyItem->getEmpty();
+      if (isset($emptyItem->fields['contact'])) {
+         $dparams['displaywith'][] = 'contact';
+      }
+      if (isset($emptyItem->fields['serial'])) {
+         $dparams['displaywith'][] = 'serial';
+      }
+      if (isset($emptyItem->fields['otherserial'])) {
+         $dparams['displaywith'][] = 'otherserial';
+      }
+      if ($itemtype === Ticket::class && !array_search('id', $dparams['displaywith'])) {
+         $dparams['displaywith'][] = 'id';
+      }
+
+      return $dparams;
+   }
+
    public function equals($value): bool {
       $value = html_entity_decode($value);
       $itemtype = $this->getSubItemtype();

Original file line number	Diff line number	Diff line change
`@@ -352,18 +352,6 @@ public function buildParams($rand = null) {`
`352`	`352`	`}`
`353`	`353`	`}`
`354`	`354`
`355`		`- $emptyItem = new $itemtype();`
`356`		`- $emptyItem->getEmpty();`
`357`		`- if (isset($emptyItem->fields['serial'])) {`
`358`		`- $dparams['displaywith'][] = 'serial';`
`359`		`- }`
`360`		`- if (isset($emptyItem->fields['otherserial'])) {`
`361`		`- $dparams['displaywith'][] = 'otherserial';`
`362`		`- }`
`363`		`- if ($itemtype === Ticket::class && !array_search('id', $dparams['displaywith'])) {`
`364`		`- $dparams['displaywith'][] = 'id';`
`365`		`- }`
`366`		`-`
`367`	`355`	`return $dparams;`
`368`	`356`	`}`
`369`	`357`