Skip to content

Commit 6c901b2

Browse files
committed
fix split mode hover (remove outdated logic)
1 parent ec46856 commit 6c901b2

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

src/traces/ohlc/hover.js

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -99,17 +99,6 @@ function hoverSplit(pointData, xval, yval, hovermode) {
9999
// skip the rest (for this trace) if we didn't find a close point
100100
if(!closestPoint) return [];
101101

102-
var cdIndex = closestPoint.index;
103-
var di = cd[cdIndex];
104-
var hoverinfo = di.hi || trace.hoverinfo;
105-
var hoverParts = hoverinfo.split('+');
106-
var isAll = hoverinfo === 'all';
107-
var hasY = isAll || hoverParts.indexOf('y') !== -1;
108-
109-
// similar to hoverOnPoints, we return nothing
110-
// if all or y is not present.
111-
if(!hasY) return [];
112-
113102
var attrs = ['high', 'open', 'close', 'low'];
114103

115104
// several attributes can have the same y-coordinate. We will
@@ -168,15 +157,14 @@ function hoverOnPoints(pointData, xval, yval, hovermode) {
168157
var hoverinfo = di.hi || trace.hoverinfo || '';
169158
var hoverParts = hoverinfo.split('+');
170159
var isAll = hoverinfo === 'all';
171-
var hasY = isAll || hoverParts.indexOf('y') !== -1;
172160
var hasText = isAll || hoverParts.indexOf('text') !== -1;
173161

174-
var textParts = hasY ? [
162+
var textParts = [
175163
getLabelLine('open'),
176164
getLabelLine('high'),
177165
getLabelLine('low'),
178166
getLabelLine('close') + ' ' + DIRSYMBOL[dir]
179-
] : [];
167+
];
180168
if(hasText) fillText(di, trace, textParts);
181169

182170
// don't make .yLabelVal or .text, since we're managing hoverinfo

0 commit comments

Comments
 (0)