-
|
hey there 👋 before I create an issue, I would like to know, if I get something wrong, or if there really is an issue 😁 In our project, we are using \Symfony\Component\Cache\Traits\RedisTrait::createConnection (via \Symfony\Component\Cache\Adapter\RedisAdapter) to create a Redis connection. The return type also includes
The reason was this change JetBrains/phpstorm-stubs#1772 Now I wonder, if those four methods (the only ones we are using, there might be more) are really not existing on Thanks in advance for the help |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 4 replies
-
|
Hi 👋,
Every other command is invoked via the Line 232 in c563c8c So the methods are defined in that you can call any method that I'm not sure what the best practices would be here vis-a-vis the stubs. Defining them in |
Beta Was this translation helpful? Give feedback.
-
|
hey @michael-grunder thanks a lot for your answer, that explains it 👍 |
Beta Was this translation helpful? Give feedback.
-
That should be fine, even though it's a lot of methods. The only thing we have to be careful about is changing the non-comment lines as that will affect reflection at the C layer. AFAIK any and all |
Beta Was this translation helpful? Give feedback.
-
|
I have no experience working on PHP extensions and their stubs, but I would like to give it a try. Let me create a PR and maybe you can give feedback on this? 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
hey Michael the PR is ready for review #2737 Looking forward for your feedback 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
I think this can be closed since it's been fixed in #2737 |
Beta Was this translation helpful? Give feedback.
hey Michael
the PR is ready for review #2737
Looking forward for your feedback 🙂