Add Request Pending Duration to service-members (#297)

Tim Middleton · web-flow · commit 1c7a75465cce · 2025-05-07T17:00:39.000+08:00
diff --git a/pkg/cmd/formatting.go b/pkg/cmd/formatting.go
@@ -890,10 +890,11 @@ func FormatServiceMembers(serviceMembers []config.ServiceMemberDetail) string {
 		WithSortingColumn(NodeIDColumn)
 
 	if OutputFormat == constants.WIDE {
-		table.WithAlignment(R, R, R, R, R, R, R, R, R, R, R, R)
+		table.WithAlignment(R, R, R, R, R, R, R, R, R, R, R, R, R)
 		table.AddHeaderColumns("TASK COUNT", "TASK BACKLOG", "PRIMARY OWNED",
-			"BACKUP OWNED", "REQ AVG MS", "TASK AVG MS")
+			"BACKUP OWNED", "REQ AVG MS", "TASK AVG MS", "REQ PEND MS")
 		table.AddFormattingFunction(7, errorFormatter)
+		table.AddFormattingFunction(12, errorFormatter)
 	} else {
 		table.WithAlignment(R, R, R, R, R, R)
 	}
@@ -914,7 +915,8 @@ func FormatServiceMembers(serviceMembers []config.ServiceMemberDetail) string {
 			table.AddColumnsToRow(
 				formatSmallInteger(value.TaskCount), formatSmallInteger(value.TaskBacklog),
 				formatSmallInteger(value.OwnedPartitionsPrimary), formatSmallInteger(value.OwnedPartitionsBackup),
-				formatFloat(value.RequestAverageDuration), formatFloat(value.TaskAverageDuration))
+				formatFloat(value.RequestAverageDuration), formatFloat(value.TaskAverageDuration),
+				formatLargeInteger(int64(value.RequestPendingDuration)))
 		}
 	}
 
diff --git a/pkg/config/config_helper.go b/pkg/config/config_helper.go
@@ -385,6 +385,7 @@ type ServiceMemberDetail struct {
 	OwnedPartitionsBackup  int32   `json:"ownedPartitionsBackup"`
 	RequestAverageDuration float32 `json:"requestAverageDuration"`
 	TaskAverageDuration    float32 `json:"taskAverageDuration"`
+	RequestPendingDuration float32 `json:"RequestPendingDuration"`
 }
 
 // CacheSummaries contains cache summary details.

Original file line number	Diff line number	Diff line change
`@@ -385,6 +385,7 @@ type ServiceMemberDetail struct {`
`385`	`385`	OwnedPartitionsBackup int32 `json:"ownedPartitionsBackup"`
`386`	`386`	RequestAverageDuration float32 `json:"requestAverageDuration"`
`387`	`387`	TaskAverageDuration float32 `json:"taskAverageDuration"`
	`388`	+ RequestPendingDuration float32 `json:"RequestPendingDuration"`
`388`	`389`	`}`
`389`	`390`
`390`	`391`	`// CacheSummaries contains cache summary details.`