Skip to content

Conversation

@dwhswenson
Copy link
Member

Adding config file for CodeCov. In particular, I'm hoping that I can get CodeCov to wait until the integration tests are done before adding its comment/status indicator. It's a little annoying to get the email (which, unlike the comment, doesn't update) saying CodeCov hates the PR after only the minimal test suite has come in. Also, I keep seeing the red X on a PR and checking to see where the tests went wrong, when it's really that the tests are still running and CodeCov has incomplete info.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #980 (68c7e6c) into master (3f2c0c4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   80.25%   80.26%           
=======================================
  Files         136      136           
  Lines       14452    14455    +3     
=======================================
+ Hits        11599    11602    +3     
  Misses       2853     2853           
Impacted Files Coverage Δ
openpathsampling/ensemble.py 84.59% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2c0c4...68c7e6c. Read the comment docs.

@sroet
Copy link
Member

sroet commented Feb 22, 2021

I have no real preference here, but please add a comment to .github/workflows/tests.yml to update this after_n_builds number whenever the test-matrix size changes

@dwhswenson
Copy link
Member Author

I have no real preference here, but please add a comment to .github/workflows/tests.yml to update this after_n_builds number whenever the test-matrix size changes

Done. This may solve the problem (I'm typing this when the minimal tests have been finished but the integration tests are still running; there's no complaining from codecov now.) In case there's any further need for discussion (I assume not), I will leave this open for at least 6 hours, merging no earlier than Mon 22 Feb 19:00 GMT (20:00 local).

@dwhswenson dwhswenson merged commit 7f17b40 into openpathsampling:master Feb 23, 2021
@dwhswenson dwhswenson deleted the codecov-yml branch February 23, 2021 09:02
@dwhswenson dwhswenson mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants